vttablet: create database if not present#6490
Merged
sougou merged 2 commits intovitessio:masterfrom Aug 1, 2020
Merged
Conversation
This functionality facilitates the use case where we connect to an externally managed mysql, but whose database has not been created yet. If the DB we look for is not found, we can just create it. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The feature to auo-create the database causes ISM to hang because it enforces semi-synch before it sets the tablet type. Enforcing semi-sync after tablet has become master allows the tabletserver to create the database without getting stuck waiting for yet-to-be-initialized replicas to ack. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
systay
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses the use where we are initializing an externally managed mysql server, but which is empty. In this case, we should create the database.
I've implemented the db creation in the tabletserver. This means that ISM also does not need to create the database. However, this change causes ISM to hang (waiting for semi-sync) because the db creation happens before the replicas are pointed at the master. To work around this, I've moved the enforcement of semi-sync until after the db is created.
This change opens up two corner cases, both of which are unlikely in a production environment:
Finally, this is temporary. Within the next few PRs, ISM will be replaced by a version that happens automatically within vttablet itself.